-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error on subclassing Dict[Any, ...] #657
Comments
This is not supported in 2.0, we can just straight to error with it. |
I think the idea is that this is is a reminder for 2.2 to remove the deprecation warning from extending Dict and make it an error. (We can also just allow but completely ignore it). |
I thought the idea was that subclassing If you still want to go that route, I can try to get a PR ready tonight. |
Oh yeah, sorry. |
Closing since we've already deprecated subclassing Dict in general. |
Based on #502 (comment), it is proposed to deprecate support for structured configs that subclass
Dict[Any, ...]
, with only subclasses ofDict[str, ...]
being supported going forward.For example, creating a structured config node based on the following dataclass would issue a deprecation warning,
while a structured config node based on the following would be fully supported:
The text was updated successfully, but these errors were encountered: