Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented and tested __contains__ (key in cfg) #49

Merged
merged 1 commit into from
Oct 26, 2019
Merged

implemented and tested __contains__ (key in cfg) #49

merged 1 commit into from
Oct 26, 2019

Conversation

omry
Copy link
Owner

@omry omry commented Oct 26, 2019

implemented contains in DictConfig.

A key is in a dict if there is an associated value that is not None and does not result in a MissingMandatoryValue or KeyError exceptions.

@coveralls
Copy link

coveralls commented Oct 26, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 249

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 99.188%
Totals Coverage Status
Change from base Build 246: -0.07%
Covered Lines: 2443
Relevant Lines: 2463
💛 - Coveralls

@omry
Copy link
Owner Author

omry commented Oct 26, 2019

Closes #50

@omry omry closed this Oct 26, 2019
@omry omry reopened this Oct 26, 2019
@omry omry merged commit 345d45d into master Oct 26, 2019
@omry omry mentioned this pull request Nov 19, 2019
Merged
@omry omry deleted the in branch November 28, 2019 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omry @coveralls