Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging into an interpolation with a custom resolver that raises an exception fails the merge. #486

Closed
omry opened this issue Jan 22, 2021 · 0 comments · Fixed by #487
Closed
Labels
bug Something isn't working
Milestone

Comments

@omry
Copy link
Owner

omry commented Jan 22, 2021

Merging into an interpolation with a custom resolver that raises an exception fails the merge.

Test:

    def fail():
        raise ValueError()

    OmegaConf.register_resolver("fail", fail)

    configs = (
        {"d": 20, "i": "${fail:}"},
        {"i": "zzz"},
    )
    expected = {"d": 20, "i": "zzz"}
    assert OmegaConf.merge(*configs) == expected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant