struct config is not behaving as dict. when calling get

[shay-te]

Describe the bug
struct config is not behaving as dict.
in python

d = {}
d['a']  # raise KeyError
d.get('a') # return null

DictConfig is expected to behave the same
currently struct DictConfg is throwing a exception

To Reproduce

cfg = OmegaConf.create({})
OmegaConf.set_struct(cfg, True)
conf.get('not exists key')

Expected behavior

conf.get('not exists key'). # will return None without raising an exception

[omry]

Thanks for reporting, this does seem like a bug.
I will take a look at it for 2.1, for now try to specify a default None on the callsite:

cfg = OmegaConf.create({})
OmegaConf.set_struct(cfg, True)
conf.get('not exists key', None)

[guillaumegenthial]

I observed the same behavior with pop (when a default is specified).

To reproduce

from dataclasses import dataclass
from enum import Enum
from omegaconf import OmegaConf
from typing import Dict


class Color(Enum):
    RED = "red"
    GREEN = "green"
    BLUE = "blue"


@dataclass
class ColorConf:
    colors: Dict[Color, float] = None


from omegaconf import OmegaConf
from dataclasses import dataclass
from enum import Enum
from typing import Dict


class Color(Enum):
    RED = "red"
    GREEN = "green"
    BLUE = "blue"


@dataclass
class ColorConf:
    colors: Dict[Color, float] = None


config = OmegaConf.structured(ColorConf({Color.RED: 0.1}))
print(config.colors.pop(Color.RED, None))  # 0.1
print(config.colors.pop(Color.BLUE, None))  # None
config.colors.pop("blue", None)  # Errors with any key that is not Enum

which raises

omegaconf.errors.KeyValidationError: Key 'blue' is incompatible with the enum type 'Color', valid: [RED, GREEN, BLUE]
	full_key: colors.blue
	reference_type=Dict[Color, float]
	object_type=dict

Even though this is unexpected, it might be the intended behavior.

[omry]

@guillaumegenthial , at a glance, it looks like a different problem. can you file another issue?

[guillaumegenthial]

sure.

EDIT: #471