Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dot-keys usage warning and abort compact keys plan. #332

Closed
omry opened this issue Aug 18, 2020 · 0 comments · Fixed by #333
Closed

Remove dot-keys usage warning and abort compact keys plan. #332

omry opened this issue Aug 18, 2020 · 0 comments · Fixed by #333

Comments

@omry
Copy link
Owner

omry commented Aug 18, 2020

OmegaConf 2.0 started to warn about usage of keys with dot (a.b.c: 10) in preparation for compact keys (#152).
Turns out this is causing too many issues and the pressure for compact keys went down significantly:

  1. Hydra's packages serves almost the exact same purpose with a less disruptive change to the yaml semantics.
  2. Hydra itself is already using dot keys for package override, for example:
defaults:
 - [email protected]: bar

Would place the content of foo/bar.yaml in the package a.b.c ({a:{b:{c: ... }}}).
This is a dot key that is currently issuing a warning from OmegaConf.

For these reasons, I decided to abandon the idea of compact key support in OmegaConf and I am removing warning on usage of dot keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant