New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging structured class with a wrong dict doesn't raise an exception. #327

Closed

pereman2 opened this issue Aug 12, 2020 · 0 comments · Fixed by #330

Labels

bug

Milestone

OmegaConf 2.0.1

Contributor

pereman2 commented Aug 12, 2020 •

edited by omry

Loading

Example :

@dataclass
class Module:
    name: str = MISSING
    classes: List[str] = MISSING


@dataclass
class Config:
    modules: List[Module] = MISSING

print(OmegaConf.merge(Config, {"modules": [{"should_error": "foo"}]}))

omry added the bug label

omry added this to the OmegaConf 2.0.1 milestone

pereman2 mentioned this issue

fix merge list of structured class #330

Merged

omry closed this as completed in #330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment