Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs in handling of config flags and config merges #301

Closed
omry opened this issue Jul 14, 2020 · 0 comments · Fixed by #302
Closed

Bugs in handling of config flags and config merges #301

omry opened this issue Jul 14, 2020 · 0 comments · Fixed by #302
Milestone
OmegaConf 2.0.1

Comments

@omry
Copy link
Owner

omry commented Jul 14, 2020

  1. Message in read-only error on merge is is not helpful.
  2. merge_with does not copy the flags from the merged node.
@omry omry added this to the OmegaConf 2.0.1 milestone Jul 14, 2020
@omry omry linked a pull request Jul 15, 2020 that will close this issue
merge_with() now copied flags (readonly, struct) into target config #302
Merged
@omry omry closed this as completed Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
OmegaConf 2.0.1
Development

Successfully merging a pull request may close this issue.

merge_with() now copied flags (readonly, struct) into target config omry/omegaconf
1 participant
@omry