Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit extending typing.List and typing.Dict in ListConfig and DictConfig #270

Closed
omry opened this issue Jun 19, 2020 · 4 comments
Closed

Revisit extending typing.List and typing.Dict in ListConfig and DictConfig #270

omry opened this issue Jun 19, 2020 · 4 comments
Milestone
OmegaConf 2.1

Comments

@omry
Copy link
Owner

omry commented Jun 19, 2020

I tried it before and could not make it work.
can try again for 2.1.
@omry omry added this to the OmegaConf 2.1 milestone Jun 19, 2020
@omry
Copy link
Owner Author

omry commented Jun 20, 2020

Some context on why I think extending MutableSequence and MutableMapping is the way to go:
https://treyhunner.com/2019/04/why-you-shouldnt-inherit-from-list-and-dict-in-python/

I will take a closer look at this for 2.1.

@omry
Copy link
Owner Author

omry commented Sep 11, 2020

not going to happen.

@omry omry closed this as completed Sep 11, 2020
@wookayin
Copy link

May I ask what is blocking you?

@omry
Copy link
Owner Author

omry commented Sep 11, 2020

This is a breaking change and I don't think it's worth it.
OmegaConf containers are extending MutableSequence and MutableMapping and this should be good enough.

@omry omry mentioned this issue Oct 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
OmegaConf 2.1
Development

No branches or pull requests
2 participants
@omry @wookayin