Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax save and load APIs to accept IO[Any] #253

Closed
omry opened this issue May 12, 2020 · 0 comments · Fixed by #254
Closed

Relax save and load APIs to accept IO[Any] #253

omry opened this issue May 12, 2020 · 0 comments · Fixed by #254

Comments

@omry
Copy link
Owner

omry commented May 12, 2020

Per comment here:

open(fn, 'rb') will now return IO[bytes] while open(fn, 'r') will return IO[str]

For easier to use API, it's best to change to IO[Any] to accept files opened in either modes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant