Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate behavior of overlaying PostGreSQLConfig() over db: DBConfig = MySQLConfig() #164

Closed
omry opened this issue Mar 10, 2020 · 0 comments · Fixed by #187
Closed

Validate behavior of overlaying PostGreSQLConfig() over db: DBConfig = MySQLConfig() #164

omry opened this issue Mar 10, 2020 · 0 comments · Fixed by #187
Milestone
OmegaConf 2.0.0

Comments

@omry
Copy link
Owner

omry commented Mar 10, 2020 

@dataclass
class Config(DictConfig):
    db: DBConfig = MySQLConfig()

Validate that this behavior makes sense, this seems wrong.

$ python examples/structured_configs_tutorial/4_config_groups/my_app_with_inheritance.py database=postgresql
...
omegaconf.errors.ValidationError: Invalid type assigned : PostGreSQLConfig is not a subclass of MySQLConfig
@omry omry added this to the OmegaConf 2.0 milestone Mar 10, 2020
@omry omry mentioned this issue Apr 5, 2020
Merged
@omry omry closed this as completed in #187 Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
OmegaConf 2.0.0
Development

Successfully merging a pull request may close this issue.

Major internal rewrite omry/omegaconf
1 participant
@omry