OUIEditMenuController inhibitMenuFor incorrect assertion

[memmons]

inhibitMenuFor is found in OUIEditMenuController and is called by ancestorScrollViewWillBeginScrolling in OUIEditableFrame. Likewise, uninhibitMenuFor is called by ancestorScrollViewDidEndScrolling. The assumption this code makes is that each begin scrolling event will be balanced by an end scrolling event. However, this is not the case. Any time the direction of scrolling is changed before scrolling has finished, inhibitMenuFor will be called without a uninhibitMenuFor balancing it out. In these cases the OBASSERT will fail in inhibitMenuFor. No harm done since the inhibitions set will not add an existing object, but likely this assertion should be removed.

- (void)inhibitMenuFor:(NSString *)cause;
{
    DEBUG_MENU(@"%s: %@", __func__, self);
    DEBUG_MENU(@"Inhibiting for: %@", cause);

    OBASSERT([inhibitions member:cause] == nil);
    [inhibitions addObject:cause];
    [self _updateMainMenuVisibility];
}

- (void)uninhibitMenuFor:(NSString *)cause;
{
    DEBUG_MENU(@"%s: %@", __func__, self);
    DEBUG_MENU(@"Overcoming inhibition for: %@", cause);

    OBASSERT([inhibitions member:cause] != nil);
    [inhibitions removeObject:cause];

    [self _updateMainMenuVisibility];
}

[/code]