Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web3 beta.50 issues #204

Closed
patitonar opened this issue Mar 27, 2019 · 1 comment
Closed

Web3 beta.50 issues #204

patitonar opened this issue Mar 27, 2019 · 1 comment
Assignees

Comments

@patitonar
Copy link

As part of #196 we upgraded web3 to version 1.0.0-beta.50.

The following issues need to be fixed:

  1. Ee2 tests are failing with error:
Uncaught (in promise) TypeError: this.connection.on is not a function
    at MetamaskProvider.registerEventListeners (web3-providers.umd.js:929)
    at MetamaskProvider.AbstractSocketProvider (web3-providers.umd.js:135)
    at new MetamaskProvider (web3-providers.umd.js:922)
    at ProvidersModuleFactory.createMetamaskProvider (web3-providers.umd.js:1246)
    at ProviderResolver.resolve (web3-providers.umd.js:57)
    at Web3.AbstractWeb3Module (web3-core.umd.js:21)
    at new Web3 (web3.umd.js:24)
    at _callee$ (web3.js:24)
    at tryCatch (runtime.js:62)
    at Generator.invoke [as _invoke] (runtime.js:296)
    at Generator.prototype.(:3000/anonymous function) [as next] (http://10.1.0.101:3000/static/js/bundle.js:93419:21)
    at step (testUtils.js:21)
    at testUtils.js:21
    at new Promise (<anonymous>)
    at testUtils.js:21

This is possibly a error caused by the different versions of web3 used on the Metamask extension and the app. A solution could be to upgrade Metamask extension on the e2e tests.

  1. Error: Empty outputs array given! see this comment Use chainId instead of networkId #196 (comment)

  2. Error: Transaction has been reverted by the EVM even if transaction was successful. see this comment Use chainId instead of networkId #196 (comment)

@akolotov
Copy link
Collaborator

akolotov commented Apr 1, 2019

The issue is not applicable any more after migration back to web3js v1.0.0-beta.30

@akolotov akolotov closed this as completed Apr 1, 2019
@ghost ghost removed the review label Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants