-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update leaflet library to provide a11y improvements #56
Comments
The update-leaflet-library branch updates the Leaflet library to v1.9. Hopefully that'll address the issues. |
Yes, I'd looked into this a week or so ago. The "close" button should definitely be included in this update. Not sure about the others. |
I can confirm the close button issue is resolved, as well as the map markers now being navigable via keyboard. I think there are some other elements we have to do ourselves: it seems currently not possible to navigate to popup pane content once a map marker is clicked, and we need a better aria role for the map itself. |
The update here is merged, along with updates to the other two leaflet-related dependencies we use. Other things I'll note here:
|
I've provided the item title as an I think I'd be okay with the manual updates getting pulled in. We could always upgrade again whenever they do a formal release including any future fixes. |
An accessibility audit has flagged a number of challenges for screen readers:
I think Geolocation is currently using Leaflet 1.6.0, and there have been several accessibility updates since that may address these issues.
The text was updated successfully, but these errors were encountered: