Default support for "field IS NULL" condition #749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Expected:
Actual:
And then you get error, because
null
is not passed as extra parameter into prepared statement.I know, it won't fix calls like:
Should I fix NULL in arrays as well? So it would produce SQL like:
WHERE (item_type_id IN (1,2) OR item_type_id IS NULL)
?I'm not 100% sure if this change doesn't break it for other Omeka users calling
parent::applySearchFilters()
from their plugins, but I checked few plugins (ExhibitBuilder, SimplePages, HistoryLog) and it's OK.