Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child links in navigation not accessible via keyboard #42

Open
katknow opened this issue Dec 2, 2024 · 1 comment
Open

Child links in navigation not accessible via keyboard #42

katknow opened this issue Dec 2, 2024 · 1 comment

Comments

@katknow
Copy link

katknow commented Dec 2, 2024

Currently, the navigation fails the Accessibility Insights for Web assessment when child links are added to the navigation bar. While you can technically tab to them, it does so without opening the menu so it looks like you are tabbing to nothing. The navigation menu would need to be able to be opened and closed by keyboard to pass.

@kimisgold
Copy link
Contributor

I've attempted to address this in b362181 and dc5c96b and the other previously referenced commits. The top nav should now be navigable by keyboard.

  • The arrow buttons will open and close child menus when hovered in and out on as well as by click.
  • On keyboard, tabbing out of a branch of the nav tree will close the child menu. Only one branch should be visible at a time.

This should be tested with screen readers on the major desktop and mobile browsers. I can cover android devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants