Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden download button in "Activities" #377

Closed
Tom-TBT opened this issue Jun 2, 2022 · 2 comments · Fixed by #378
Closed

Hidden download button in "Activities" #377

Tom-TBT opened this issue Jun 2, 2022 · 2 comments · Fixed by #378

Comments

@Tom-TBT
Copy link
Contributor

Tom-TBT commented Jun 2, 2022

Hello,
Following "Run script"->"export scripts"-> "Batch Image Export..."
the "Download File" button in "Activities" gets hidden when the exported Image_name or Folder_name is too long

notFitting

After some testing, this happens only when there is no space in the name, adding a space let it print the name on several lines:
Fitting space

Additionally, this affects previous notifications (but is reset if we clear the list):
notFitting_anymore

A quick workaround is to select first an image with a short name (that's the one that will be printed in the "Activities").

Looking around the possibilities to fix that, a quick but dirty solution is to trim the message displayed when too long. That could be done in the concerned script (Batch_Image_Export.py#L615).

The second and better solution, in my opinion, is to handle it in omero-web, as other messages could be concerned. But this is the point where I'm getting lost in the code...

Best,
Tom

@will-moore
Copy link
Member

Thanks for reporting this - I'll look into it...

@will-moore
Copy link
Member

The fix for this at #378 has now been released in omero-web 5.15.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants