Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix]: specify depth in npm ls to avoid errors from uninstalled peerDeps #1

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

kindoflew
Copy link
Contributor

In npm v8, the ls command will default to --depth=0, but to be safe, we'll include it for now.

Context:
While attempting to run the CLI in a project that had some dependencies with missing peerDeps, it crashed because of npm errors relating to them. Using depth=0 explicitly will avoid this because dependencies (prod, dev, and peer) that are specified in package.json will always be included after npm install.

@kindoflew kindoflew merged commit 287a857 into main Sep 28, 2022
@kindoflew kindoflew deleted the fix/list-depth branch September 28, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant