Skip to content
This repository has been archived by the owner on Aug 23, 2021. It is now read-only.

Port remaining tests. #382

Open
6 of 8 tasks
lmwnshn opened this issue Jul 26, 2021 · 2 comments
Open
6 of 8 tasks

Port remaining tests. #382

lmwnshn opened this issue Jul 26, 2021 · 2 comments
Assignees
@lmwnshn

Comments

@lmwnshn
Copy link
Collaborator

lmwnshn commented Jul 26, 2021 •
edited
Loading

  • TestStatementDialects -- Need to port.
  • TestAuctionMarkLoader
  • TestAuctionMarkWorker
  • TestUserIdGenerator
  • TestSEATSLoader
  • TestSEATSWorker
  • TestTATPWorker
  • TestCatalog -- Need to port. This is really TestHSQLDBCatalog now. There are two catalog types, HSQLDB and the "real" catalog version that Tim brought in.

Fixes:

  • hsqldb doesn't like empty executeBatch() calls
  • The AuctionMarkProfile is stored in the AuctionMarkLoader, (same as SEATS). The old version (oltpbench 1) created a Loader, didn't use it because super.testLoad() invokes loadDatabase which makes a new Loader, but somehow we expected the first profile to have gotten the writes? It isn't static or shared afaik. Maybe everything worked because it was all on the same Connection object.
@lmwnshn lmwnshn self-assigned this Jul 26, 2021
@lmwnshn lmwnshn mentioned this issue Jul 29, 2021
Open
20 tasks
@lmwnshn
Copy link
Collaborator Author

lmwnshn commented Jul 29, 2021 •
edited
Loading

FWIW this is what the old tests used to do:

Travis

junit:
     [copy] Copying 1 file to /home/travis/build/oltpbenchmark/oltpbench/build
    [mkdir] Created dir: /home/travis/build/oltpbenchmark/oltpbench/build/testoutput
    [junit] WARNING: multiple versions of ant detected in path for junit 
    [junit]          jar:file:/usr/share/ant/lib/ant.jar!/org/apache/tools/ant/Project.class
    [junit]      and jar:file:/home/travis/build/oltpbenchmark/oltpbench/lib/ant-1.6.5.jar!/org/apache/tools/ant/Project.class
    [junit] Running com.oltpbenchmark.api.TestCreateDialects
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.075 sec
    [junit] Running com.oltpbenchmark.api.TestProcedure
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.343 sec
    [junit] Running com.oltpbenchmark.api.TestSQLStmt
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.384 sec
    [junit] Running com.oltpbenchmark.api.TestStatementDialects
    [junit] WARNING: An illegal reflective access operation has occurred
    [junit] WARNING: Illegal reflective access by com.sun.xml.bind.v2.runtime.reflect.opt.Injector (file:/home/travis/build/oltpbenchmark/oltpbench/lib/jaxb-impl-2.3.0.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int)
    [junit] WARNING: Please consider reporting this to the maintainers of com.sun.xml.bind.v2.runtime.reflect.opt.Injector
    [junit] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
    [junit] WARNING: All illegal access operations will be denied in a future release
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.845 sec
    [junit] Running com.oltpbenchmark.benchmarks.auctionmark.TestAuctionMarkBenchmark
    [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.826 sec
    [junit] Running com.oltpbenchmark.benchmarks.auctionmark.TestAuctionMarkWorker
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 28.863 sec
    [junit] Running com.oltpbenchmark.benchmarks.auctionmark.util.TestItemId
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.287 sec
    [junit] Running com.oltpbenchmark.benchmarks.auctionmark.util.TestUserId
    [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.398 sec
    [junit] Running com.oltpbenchmark.benchmarks.auctionmark.util.TestUserIdGenerator
    [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.644 sec
    [junit] Running com.oltpbenchmark.benchmarks.chbenchmark.TestCHBenCHmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.489 sec
    [junit] Running com.oltpbenchmark.benchmarks.epinions.TestEpinionsBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.666 sec
    [junit] Running com.oltpbenchmark.benchmarks.noop.TestNoOpBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.497 sec
    [junit] Running com.oltpbenchmark.benchmarks.resourcestresser.TestResourceStresserBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.475 sec
    [junit] Running com.oltpbenchmark.benchmarks.seats.TestSEATSBenchmark
    [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.779 sec
    [junit] Running com.oltpbenchmark.benchmarks.seats.TestSEATSLoader
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.171 sec
    [junit] Running com.oltpbenchmark.benchmarks.seats.TestSEATSWorker
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.93 sec
    [junit] Running com.oltpbenchmark.benchmarks.seats.util.TestCustomerId
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.281 sec
    [junit] Running com.oltpbenchmark.benchmarks.seats.util.TestCustomerIdIterable
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.317 sec
    [junit] Running com.oltpbenchmark.benchmarks.seats.util.TestDistanceUtil
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.308 sec
    [junit] Running com.oltpbenchmark.benchmarks.seats.util.TestFlightId
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.303 sec
    [junit] Running com.oltpbenchmark.benchmarks.seats.util.TestReturnFlight
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.308 sec
    [junit] Running com.oltpbenchmark.benchmarks.smallbank.TestSmallBankBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.44 sec
    [junit] Running com.oltpbenchmark.benchmarks.smallbank.TestSmallBankLoader
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.456 sec
    [junit] Running com.oltpbenchmark.benchmarks.smallbank.TestSmallBankWorker
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.549 sec
    [junit] Running com.oltpbenchmark.benchmarks.tatp.TestTATPBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.453 sec
    [junit] Running com.oltpbenchmark.benchmarks.tatp.TestTATPLoader
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.047 sec
    [junit] Running com.oltpbenchmark.benchmarks.tatp.TestTATPWorker
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.482 sec
    [junit] Running com.oltpbenchmark.benchmarks.tpcc.TestTPCCBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.526 sec
    [junit] Running com.oltpbenchmark.benchmarks.tpcc.TestTPCCLoader
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.407 sec
    [junit] Running com.oltpbenchmark.benchmarks.twitter.TestTwitterBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.549 sec
    [junit] Running com.oltpbenchmark.benchmarks.twitter.TestTwitterLoader
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.207 sec
    [junit] Running com.oltpbenchmark.benchmarks.voter.TestVoterBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.421 sec
    [junit] Running com.oltpbenchmark.benchmarks.voter.TestVoterLoader
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.9 sec
    [junit] Running com.oltpbenchmark.benchmarks.voter.TestVoterWorker
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.111 sec
    [junit] Running com.oltpbenchmark.benchmarks.wikipedia.TestWikipediaBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.89 sec
    [junit] Running com.oltpbenchmark.benchmarks.wikipedia.TestWikipediaLoader
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.594 sec
    [junit] Running com.oltpbenchmark.benchmarks.ycsb.TestYCSBBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.431 sec
    [junit] Running com.oltpbenchmark.benchmarks.ycsb.TestYCSBLoader
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.966 sec
    [junit] Running com.oltpbenchmark.catalog.TestCatalog
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.562 sec
    [junit] Running com.oltpbenchmark.util.TestClassUtil
    [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.33 sec
    [junit] Running com.oltpbenchmark.util.TestCollectionUtil
    [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.273 sec
    [junit] Running com.oltpbenchmark.util.TestFileUtil
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.338 sec
    [junit] Running com.oltpbenchmark.util.TestHistogram
    [junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.336 sec
    [junit] Running com.oltpbenchmark.util.TestRandomDistribution
    [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.069 sec
    [junit] Running com.oltpbenchmark.util.TestTableDataIterable
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.196 sec
    [junit] Running com.oltpbenchmark.util.TestTextGenerator
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.659 sec
    [junit] Running com.oltpbenchmark.util.TestThreadUtil
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.379 sec

Locally

git/oltpbench [master] » ant junit
Buildfile: /home/cmu-db-nuc-wan/git/oltpbench/build.xml

build:

junit:
     [copy] Copying 1 file to /home/cmu-db-nuc-wan/git/oltpbench/build
    [mkdir] Created dir: /home/cmu-db-nuc-wan/git/oltpbench/build/testoutput
    [junit] WARNING: multiple versions of ant detected in path for junit
    [junit]          jar:file:/home/cmu-db-nuc-wan/git/oltpbench/lib/ant-1.6.5.jar!/org/apache/tools/ant/Project.class
    [junit]      and jar:file:/usr/share/ant/lib/ant.jar!/org/apache/tools/ant/Project.class
    [junit] Running com.oltpbenchmark.api.TestCreateDialects
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.327 sec
    [junit] Running com.oltpbenchmark.api.TestProcedure
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.081 sec
    [junit] Running com.oltpbenchmark.api.TestSQLStmt
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.077 sec
    [junit] Running com.oltpbenchmark.api.TestStatementDialects
    [junit] Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 0.473 sec
    [junit] Test com.oltpbenchmark.api.TestStatementDialects FAILED
    [junit] Running com.oltpbenchmark.benchmarks.auctionmark.TestAuctionMarkBenchmark
    [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.667 sec
    [junit] Running com.oltpbenchmark.benchmarks.auctionmark.TestAuctionMarkWorker
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.823 sec
    [junit] Running com.oltpbenchmark.benchmarks.auctionmark.util.TestItemId
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.06 sec
    [junit] Running com.oltpbenchmark.benchmarks.auctionmark.util.TestUserId
    [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.154 sec
    [junit] Running com.oltpbenchmark.benchmarks.auctionmark.util.TestUserIdGenerator
    [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.511 sec
    [junit] Running com.oltpbenchmark.benchmarks.chbenchmark.TestCHBenCHmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.543 sec
    [junit] Running com.oltpbenchmark.benchmarks.epinions.TestEpinionsBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.546 sec
    [junit] Running com.oltpbenchmark.benchmarks.noop.TestNoOpBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.549 sec
    [junit] Running com.oltpbenchmark.benchmarks.resourcestresser.TestResourceStresserBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.579 sec
    [junit] Running com.oltpbenchmark.benchmarks.seats.TestSEATSBenchmark
    [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.738 sec
    [junit] Running com.oltpbenchmark.benchmarks.seats.TestSEATSLoader
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.53 sec
    [junit] Running com.oltpbenchmark.benchmarks.seats.TestSEATSWorker
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.147 sec
    [junit] Running com.oltpbenchmark.benchmarks.seats.util.TestCustomerId
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.06 sec
    [junit] Running com.oltpbenchmark.benchmarks.seats.util.TestCustomerIdIterable
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.075 sec
    [junit] Running com.oltpbenchmark.benchmarks.seats.util.TestDistanceUtil
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.058 sec
    [junit] Running com.oltpbenchmark.benchmarks.seats.util.TestFlightId
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.059 sec
    [junit] Running com.oltpbenchmark.benchmarks.seats.util.TestReturnFlight
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.059 sec
    [junit] Running com.oltpbenchmark.benchmarks.smallbank.TestSmallBankBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.488 sec
    [junit] Running com.oltpbenchmark.benchmarks.smallbank.TestSmallBankLoader
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.651 sec
    [junit] Running com.oltpbenchmark.benchmarks.smallbank.TestSmallBankWorker
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.519 sec
    [junit] Running com.oltpbenchmark.benchmarks.tatp.TestTATPBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.509 sec
    [junit] Running com.oltpbenchmark.benchmarks.tatp.TestTATPLoader
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.324 sec
    [junit] Running com.oltpbenchmark.benchmarks.tatp.TestTATPWorker
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.466 sec
    [junit] Running com.oltpbenchmark.benchmarks.tpcc.TestTPCCBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.58 sec
    [junit] Running com.oltpbenchmark.benchmarks.tpcc.TestTPCCLoader
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.943 sec
    [junit] Running com.oltpbenchmark.benchmarks.twitter.TestTwitterBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.497 sec
    [junit] Running com.oltpbenchmark.benchmarks.twitter.TestTwitterLoader
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.369 sec
    [junit] Running com.oltpbenchmark.benchmarks.voter.TestVoterBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.474 sec
    [junit] Running com.oltpbenchmark.benchmarks.voter.TestVoterLoader
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.311 sec
    [junit] Running com.oltpbenchmark.benchmarks.voter.TestVoterWorker
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.355 sec
    [junit] Running com.oltpbenchmark.benchmarks.wikipedia.TestWikipediaBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.675 sec
    [junit] Running com.oltpbenchmark.benchmarks.wikipedia.TestWikipediaLoader
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.587 sec
    [junit] Running com.oltpbenchmark.benchmarks.ycsb.TestYCSBBenchmark
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.449 sec
    [junit] Running com.oltpbenchmark.benchmarks.ycsb.TestYCSBLoader
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.297 sec
    [junit] Running com.oltpbenchmark.catalog.TestCatalog
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.591 sec
    [junit] Running com.oltpbenchmark.util.TestClassUtil
    [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.085 sec
    [junit] Running com.oltpbenchmark.util.TestCollectionUtil
    [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.062 sec
    [junit] Running com.oltpbenchmark.util.TestFileUtil
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.08 sec
    [junit] Running com.oltpbenchmark.util.TestHistogram
    [junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.065 sec
    [junit] Running com.oltpbenchmark.util.TestRandomDistribution
    [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.482 sec
    [junit] Running com.oltpbenchmark.util.TestTableDataIterable
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.441 sec
    [junit] Running com.oltpbenchmark.util.TestTextGenerator
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.636 sec
    [junit] Running com.oltpbenchmark.util.TestThreadUtil
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.098 sec

BUILD FAILED
/home/cmu-db-nuc-wan/git/oltpbench/build.xml:220: JUnit had failures

Total time: 48 seconds

@lmwnshn lmwnshn mentioned this issue Jul 30, 2021
Merged
@lmwnshn
Copy link
Collaborator Author

lmwnshn commented Aug 6, 2021

#389 fixes a little more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lmwnshn lmwnshn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lmwnshn