Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcemaps missing mappings for closing brace #201

Closed
tyson-benson opened this issue Oct 18, 2015 · 3 comments
Closed

Sourcemaps missing mappings for closing brace #201

tyson-benson opened this issue Oct 18, 2015 · 3 comments

Comments

@tyson-benson
Copy link
Contributor

Hi there,

Great work on the plugin so far, I found an issue using the sourcemaps, there is no mapping produced for the closing brace for control blocks and functions. For example, when debugging in Chrome i can put a breakpoint on the third line in the source mapped TypeScript before applying ng-annotate example below:

var foo = () => {
    doSomething();
} // <-- can put breakpoint here
if (condition) {
    foo();
} // <-- can put breakpoint here

But after using ng-annotate, the lines on which i can put breakpoints are limited to the top two in the examples above. Is there a possibility you can change the sourcemap generator to create the appropriate mappings to preserve support for this?

Let me know if you need more info, it is easy to reproduce. In chrome it is easier to spot, as the lines with a closing brace are grayed out and you cannot insert the breakpoints.

@olov
Copy link
Owner

olov commented Oct 19, 2015

Thanks for the bug report - this is hopefully easy to fix. @smrq would you be able to take a look at it?

@olov
Copy link
Owner

olov commented Dec 1, 2015

I'd merge a PR fixing this issue.

@olov
Copy link
Owner

olov commented Jun 8, 2016

#245

@olov olov closed this as completed Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants