Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API - Check the type of 'component_in' API parameters #2

Closed
RGNagel opened this issue Dec 23, 2020 · 2 comments
Closed

API - Check the type of 'component_in' API parameters #2

RGNagel opened this issue Dec 23, 2020 · 2 comments
Assignees
@ollixx
Labels
implemented Work is done. Waiting for release.

Comments

@RGNagel
Copy link

RGNagel commented Dec 23, 2020

Hello,

I just started using this library and it is very great. It will be very convenient for my application. I have been doing something similar to it by using subflows + assert node + comments to provide similar API.

I would like to suggest an addition: to check the type of each input parameter. If the input type (number, string, boolean, ...) is not the expected type conforming to the defined API, then throw an error. Maybe you could add an option (checkbox) so the user can choose if they want to check or not the types.

Keep up the good work,
Thank you
@RGNagel RGNagel changed the title API - Check the type of 'comp start' node inputs API - Check the type of 'component_in' node inputs Dec 23, 2020
@RGNagel RGNagel changed the title API - Check the type of 'component_in' node inputs API - Check the type of 'component_in' API parameters Dec 23, 2020
@ollixx
Copy link
Owner

ollixx commented Jan 9, 2021

Hey,
Thanks for your request. It absolutely makes sense to validate the input.

Sorry for the late reply.
I have very little time to work on this project, so it might take while before I actually will consider your request.
BUT: I am still on it and will try to find the time in the near future.
Cheers

@ollixx ollixx self-assigned this Jul 25, 2021
@ollixx ollixx added the implemented Work is done. Waiting for release. label Jul 26, 2021
@ollixx
Copy link
Owner

ollixx commented Jul 28, 2021

released with 0.1.9

@ollixx ollixx closed this as completed Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ollixx ollixx

Labels
implemented Work is done. Waiting for release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ollixx @RGNagel