Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only send a notification when there is an error #43

Open
Neki opened this issue Aug 8, 2019 · 2 comments · May be fixed by #56
Open

Only send a notification when there is an error #43

Neki opened this issue Aug 8, 2019 · 2 comments · May be fixed by #56

Comments

@Neki
Copy link

Neki commented Aug 8, 2019 •
edited
Loading

First thing, thanks for this module!

We would be interested in receiving notifications only when there is an error during the flux sync (to reduce notification noise - if there is no error, then we can be fairly sure that eventually changes will be applied).

I'm aware of #12 but I don't think we can use it for this purpose.

Would you be interested in supporting such a feature? I make no promises that I'll have the time to provide a PR, but maybe one day if nobody beats me to it...
@Neki Neki changed the title Only send an event when there is an error Only send a notification when there is an error Aug 8, 2019
@oliviabarrick
Copy link
Owner

I’m not positive if it’s possible to do what you want using the templating feature as it is today, but I think an errors only toggle would be super useful even if it does work for that.

@gaieges
Copy link

gaieges commented Jan 17, 2020

Would love this feature as well. Do error events not come in the flux websocket stream?

@Neki Neki linked a pull request Jan 29, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the ONLY_SEND_ERRORS option, to only forward Flux errors. Destygo/fluxcloud
3 participants
@Neki @gaieges @oliviabarrick