Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The output for version flag is printed on stderr #646

Closed
nkn1111 opened this issue May 18, 2022 · 3 comments · Fixed by #662
Closed

The output for version flag is printed on stderr #646

nkn1111 opened this issue May 18, 2022 · 3 comments · Fixed by #662

Comments

@nkn1111
Copy link

nkn1111 commented May 18, 2022

Was facing an issue with the version check for the exporter. But found a similar issue on node_exporter issues which is already fixed. Linking the same here prometheus/node_exporter#1271

Can we do the same fix here?

@oliver006
Copy link
Owner

Sure, that makes sense. If you submit a PR then I can review & merge it.

@nkn1111
Copy link
Author

nkn1111 commented May 24, 2022

TBH I don't have prior knowledge in go lang. To save you some time, it's better for someone familiar with the exporter code to raise a PR. TIA.

@nkn1111
Copy link
Author

nkn1111 commented Jun 20, 2022

Thank you so much @oliver006 @ethanmdavidson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants