split bind and listen for dynamic port reading #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazel-sudz
commented
Dec 14, 2024
Comment on lines
+134
to
136
| router2.bind().await?; | ||
| router2.listen().await?; | ||
| Ok(()) |
There was a problem hiding this comment.
bind now returns the ip/port and later call to listen() must be made to actually listen. This way implementers of router (such as read shard) are able to know the port they are listening on while still supporting dynamic port assignment.
hazel-sudz
commented
Dec 14, 2024
Comment on lines
-233
to
235
| let client3 = info_server.get_router_client(); | ||
| let client4 = info_server.get_router_client(); | ||
| let router_clone_3 = Arc::clone(&info_router); | ||
| let client3 = read_shard_server.get_router_client(); | ||
| let client4 = read_shard_server.get_router_client(); | ||
| let router_clone_3 = read_shard_router.clone(); | ||
| tokio::spawn({ |
There was a problem hiding this comment.
I think this is a typo in read_shard
hazel-sudz
commented
Dec 14, 2024
| let read_shard = ReadShard::new(SocketAddrV6::new(Ipv6Addr::LOCALHOST, 8084, 0, 0)); | ||
| let read_shard = ReadShard::new(); | ||
|
|
There was a problem hiding this comment.
this is now no longer needed
Rixhee
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.