final clippy fixes (#47)

* final clippy fix

* Auto Format Changes

* add clippy check

---------

Co-authored-by: Format Bot <>

.github/workflows/clippy.yaml

@@ -0,0 +1,28 @@
+name: Run Clippy Check 
+on:
+  push:
+    branches:
+      - 'main'
+  pull_request:
+    branches: 
+      - '*'
+  workflow_dispatch:
+
+jobs:
+  test:
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest]
+    runs-on: ${{matrix.os}}
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install Rust
+        run: |
+          rustup update
+
+      - name: Run Clippy Check 
+        run: |
+          cargo clippy -- -Dwarnings

src/messages/responses/write_response.rs

@@ -27,8 +27,7 @@ impl MessagePayload for WriteResponse {
     }
 
     fn serialize(&self) -> Result<Vec<u8>> {
-        let mut buffer = Vec::new();
-        buffer.push(self.error);
+        let buffer = vec![self.error];
         Ok(buffer)
     }
 

src/read_shard.rs

@@ -53,18 +53,17 @@ impl RouterHandler for ReadShard {
         );
         let key = String::from_utf8_lossy(&req.key).into_owned();
         let value = self.data.lock().unwrap().get(&key).cloned();
-        if value.is_none() {
-            ReadResponse {
+        match value {
+            Some(value) => ReadResponse {
+                error: 0,
+                key: req.key.clone(),
+                value: value.into_bytes(),
+            },
+            None => ReadResponse {
                 error: 1,
                 key: req.key.clone(),
                 value: Vec::new(),
-            }
-        } else {
-            ReadResponse {
-                error: 0,
-                key: req.key.clone(),
-                value: value.unwrap().into_bytes(),
-            }
+            },
         }
     }
 

src/utils/test_client.rs

@@ -68,6 +68,7 @@ impl TestRouterClient {
         }
     }
 
+    #[allow(unused)]
     pub fn get_client(&self) -> RouterClient<TestRouterClientHandler> {
         self.router.get_router_client()
     }