Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for revisions without rustc #290

Closed
DaniPopes opened this issue Oct 30, 2024 · 1 comment · Fixed by #291
Closed

Add support for revisions without rustc #290

DaniPopes opened this issue Oct 30, 2024 · 1 comment · Fixed by #291

Comments

@DaniPopes
Copy link
Contributor

Currently specifying the directive @revisions <revision>... implicitly appends --cfg=<revision> -Cextra-filename=<revision> to the compile flags, assuming the command is a rustc driver.

It would be nice to be able to use this without a rustc driver for running a test multiple times with different configurations and different output files.

I was thinking to add a simple config flag that turns the implicit compile flags off, since AFAICT this is the only implicit behavior of the directive. If this is acceptable I can open a PR to implement this.

@oli-obk
Copy link
Owner

oli-obk commented Oct 30, 2024

Hmm... revisions are pretty special, but maybe we can still make them a Flag.

If we can't, we make the "command line flag adding" a Flag that you can either not set at all, or create your own version of if you want it to set env vars or different flags instead. The apply function can query the revision from the status emitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants