Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending JPEG instead of PNG? #6

Closed
antoinecla opened this issue Dec 1, 2023 · 2 comments
Closed

Sending JPEG instead of PNG? #6

antoinecla opened this issue Dec 1, 2023 · 2 comments

Comments

@antoinecla
Copy link

Hi,

Your tool is great, it works flawlessly ! I have been able to make it connect to ComfyUI on my own PC (RTX 3080) and on a remote server with a RTX 4090 (RunPod).

ComfyUI is two times faster on RunPod with the RTX 4090 (about 0.25s per image) compared to my PC. In spite of that, the frame rate remains about the same in TouchDesigner.

I am suspecting that the speed gain on the RunPod is canceled by the network speed.

It seems that the WebSocket Node in comfyui-tooling-nodes is sending the images in PNG format which is rather slow because of the image size. I would like to use the JPEG format but am unable to do so.

I have modified the code of comfyui-tooling-nodes to send JPEGs instead of PNGs but it does not to work. TouchDesigner output is black when using JPEG. Maybe your code is expecting PNGs only ?

Any suggestion how to make this work ?

Thanks again for your TD component. It is a great tool.

Antoine

@olegchomp
Copy link
Owner

olegchomp commented Dec 1, 2023

Hi! You can find it in TDComfyUI/script2_callbacks1 and referencing to this issue Acly/comfyui-tooling-nodes#2

Maybe something like:
if event == 1 and format == 2: change to if event == 1: at line 20

@antoinecla
Copy link
Author

Thanks for your speedy answer.

I will check that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants