Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to upload files within http forms. #244

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

serhiibuniak-okta
Copy link
Contributor

Note: buffered file can't be saved within vcr cassettes, thus integration test is marked for skipping. I work on solution

Copy link
Collaborator

@bretterer bretterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a major breaking change, updating the create_request method. Is that correct?

@serhiibuniak-okta
Copy link
Contributor Author

This seems to be a major breaking change, updating the create_request method. Is that correct?

Yes, that would be a breaking change, although it doesn't brake existing functionality. This change might break the client code if somebody creates requests manually, thus we can update major version if this solution is accepted.

Copy link
Collaborator

@bretterer bretterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change and needs to be called out when PR into master is made.

Base automatically changed from develop to master October 4, 2021 15:29
@serhiibuniak-okta serhiibuniak-okta mentioned this pull request Oct 4, 2021
@serhiibuniak-okta serhiibuniak-okta changed the base branch from master to develop October 26, 2021 14:40
@serhiibuniak-okta serhiibuniak-okta merged commit e93c0ed into develop Oct 26, 2021
@serhiibuniak-okta serhiibuniak-okta deleted the upload-org-logo branch October 26, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants