Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing X-Rate-Limit-* headers in response #218

Closed
nimrodeli opened this issue Jul 18, 2021 · 3 comments
Closed

Missing X-Rate-Limit-* headers in response #218

nimrodeli opened this issue Jul 18, 2021 · 3 comments

Comments

@nimrodeli
Copy link

Hey,
I was trying to check the X-Rate-Limit-* rates during requests (because we have 2 APIs using the same Okta account and we want to be aware of it) but I saw that you replace the response headers with the request.
OktaAPIResponse::__init__ self._headers = req["headers"]

Not sure if it's a bug or by intention but I'd like to have these headers' values without patch any code from the SDK :)

@serhiibuniak-okta
Copy link
Contributor

@nimrodeli Thanks for posting this issue. Those headers are used for pagination, i.e. for the next request. But, I agree, this looks a bit weird and response headers aren't available. I'm thinking about adding attribute _resp_headers to OktaAPIResponse object. Will it work for you?

@nimrodeli
Copy link
Author

Yes, sounds good.
it will solve the issue for me.

@serhiibuniak-okta
Copy link
Contributor

SDK v2.0.0 has been released, I'm closing this issue as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants