This change adds the response body output when an error occurs. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, if there is a problem with the auth flow, it's not obvious what the issue might be beyond
a generic "400" error response. In our case the swalled error was:
{"error":"invalid_grant","error_description":"The application's assurance requirements are not met by the 'subject_token'."}
This just adds that to the output.
This also does a small restructure to make use we're closing the response body per golang guidelines.
|
This looks good to me pending review from @MikeMondragon-okta |
MikeMondragon-okta
approved these changes
Dec 15, 2022
|
PR has QC errors, I need to have GH action QC merges. |
Merged
|
GA v0.1.0 has been released 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is, if there is a problem with the auth flow, it's not obvious what the issue might be beyond a generic "400" error response. In our case the swallowed error was:
{"error":"invalid_grant","error_description":"The application's assurance requirements are not met by the 'subject_token'."}
This just adds that to the output.
This also does a small restructure to make sure we're closing the response body per golang guidelines.