Fix command line arguments and non-AWS profile scoped arguments when an AWS profile is not present in the config. #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an AWS profile is not present in the config. viper.Get() returns an empty string when an AWS profile exists in the config, but has not been set. viper.Get() returns nil when the AWS profile does not exist in the config or the config file does not exist. viper.IsSet() returns will return false when the config/profile does not exist, but always returns true when the profile exists (irelevant of whether the actual key is defined). Combining these two means that: * When a config file does not exist or profile is not present in the config, IsSet will return false and the original key is returned. * When a config file does exist and the profile exists, but the config key does not exist, Get will return an empty string and the key is returned. * When a config file does exist, the profile exists and the key exists, IsSet returns true, Get returns non-empty string and the '<profile>.<config>' key is returned. Fixes okta#194 Addresses issue in okta#192
|
This does fix my use case, thanks! |
|
@shanesmith Thank you for testing it out and confirming :) :) |
monde
approved these changes
Feb 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viper.Get()returns an empty string when an AWS profile exists in the config, but has not been set.viper.Get()returns nil when the AWS profile does not exist in the config or the config file does not exist. viper.viper.IsSet()returns will return false when the config/profile does not exist, but always returns true when the profile exists (irrelevant of whether the actual key is defined).Combining these two means that:
Fixes #194
Addresses issue in #192