Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version number from binary #154

Closed
mieliespoor opened this issue Nov 15, 2023 · 1 comment
Closed

Remove version number from binary #154

mieliespoor opened this issue Nov 15, 2023 · 1 comment

Comments

@mieliespoor
Copy link

mieliespoor commented Nov 15, 2023

The release binaries for this cli have the version number in the name of the binary. Can this be removed and use standard conventions where the binary name is consistent through versions.

See: https://github.com/okta/okta-aws-cli/blob/master/.goreleaser.yaml#L18

The fix here is to change it to:

binary: '{{ .ProjectName }}'

The problem here is that when you deploy this, you also need to rename the binary as you cannot then simply call okta-aws-cli as the documentation state without renaming the binary.

I'm happy to make this pull request myself.

@monde
Copy link
Collaborator

monde commented Jan 29, 2024

I can make it so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants