Skip to content

Commit

Permalink
Merge pull request #196 from MatthewJohn/master
Browse files Browse the repository at this point in the history
Fix command line arguments and non-AWS profile scoped arguments when an AWS profile is not present in the config.
  • Loading branch information
monde authored Feb 27, 2024
2 parents 3981a31 + 7569bf2 commit 0e074e6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ func NewConfig(attrs *Attributes) (*Config, error) {

func getFlagNameFromProfile(awsProfile string, flag string) string {
profileKey := fmt.Sprintf("%s.%s", awsProfile, flag)
if awsProfile != "" && viper.Get(profileKey) != "" {
if awsProfile != "" && viper.IsSet(profileKey) && viper.Get(profileKey) != "" {
// NOTE: If the flag was from a multiple profiles keyed by aws profile
// name i.e. `staging.oidc-client-id`, set the base value to that as
// well, `oidc-client-id`, such that input validation is satisfied.
Expand Down

0 comments on commit 0e074e6

Please sign in to comment.