fix: fixed typing for shadow root element. updated tests to reflect changes #2048
Conversation
chrispulsinelli-okta
requested review from
KevinGhadyani-Okta,
benschell-okta and
a team
as code owners
packages/odyssey-storybook/.storybook/components/MuiThemeDecorator.tsx
Outdated
Show resolved
Hide resolved
chrispulsinelli-okta
force-pushed
the
cp-OKTA-670823-fix-odyssey-provider
branch
from
2e85a3a to
a9fe841
Compare
chrispulsinelli-okta
force-pushed
the
cp-OKTA-670823-fix-odyssey-provider
branch
from
a9fe841 to
cd96f2b
Compare
| const uniqueAlphabeticalId = useUniqueAlphabeticalId(); | ||
|
|
||
| const cache = useMemo( | ||
| () => | ||
| createCache({ | ||
| ...(emotionRoot && { container: emotionRoot }), | ||
| key: uniqueAlphabeticalId, | ||
| prepend: true, | ||
| nonce: window.cspNonce, | ||
| speedy: false, | ||
| }), | ||
| [emotionRoot, uniqueAlphabeticalId] | ||
| ); | ||
|
|
||
| if (withCache) { | ||
| return ( | ||
| <CacheProvider value={cache}> | ||
| <MuiThemeProvider theme={customOdysseyTheme ?? odysseyTheme}> | ||
| <OdysseyDesignTokensContext.Provider value={odysseyTokens}> | ||
| {children} | ||
| </OdysseyDesignTokensContext.Provider> | ||
| </MuiThemeProvider> | ||
| </CacheProvider> | ||
| ); | ||
| } |
There was a problem hiding this comment.
I'm concerned about the added complexity here (if we otherwise discourage use of this provider directly). BUT if it's broken as-is (and someone is using it directly instead of OdysseyProvider), then it makes sense to make it functional.
There was a problem hiding this comment.
I agree with your thoughts on this. I don't have the context on why we need this provider (since OdysseyProvider already includes this one), but I wanted to make sure that the emotion cache worked and was available should someone use this provider directly.
|
This PR removes the I want the ability to pass a custom
|
Summary
HTMLDivElementtoHTMLElementto avoid need to castOdysseyProviderOKTA-670823
Testing & Screenshots