fix: added TypeScript project references for VSCode #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinGhadyani-Okta
requested review from
a team,
ganeshsomasundaram-okta and
kamronbatmanghelich-okta
as code owners
KevinGhadyani-Okta
force-pushed
the
kg/OKTA-581346
branch
from
a518ded to
3fcdd1c
Compare
| @@ -7,11 +7,11 @@ | |||
| "sideEffects": false, | |||
| "main": "dist/index.js", | |||
| "module": "dist/index.js", | |||
| "types": "dist/index.d.ts", | |||
| "types": "dist/src/index.d.ts", | |||
There was a problem hiding this comment.
src folder in dist? That is not common, right? Can we avoid that?
There was a problem hiding this comment.
Yes. Only the TS files because isolateModules: true.
There was a problem hiding this comment.
That's how it was the whole time. I don't think it's easy or necessary to fix.
Most libraries export a single index.d.ts, but if you saw ours, this makes more sense. In the timeframe, I wasn't able to get a single index.d.ts working with outFile.
KevinGhadyani-Okta
force-pushed
the
kg/OKTA-581346
branch
from
3fcdd1c to
9a27d21
Compare
kamronbatmanghelich-okta
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VSCode would require a "TS Server" reset each time we ran a build or ran typecheck. With project references, that's no longer an issue.
Also, our type exports were looking at
dist/index.d.tswhich doesn't exist instead ofdist/src/index.d.ts.