fix: Add enquirer peer dependency #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philihp
changed the title
|
Thanks for the PR! Can you also bump the listr2 version to |
iiroj
requested changes
Jun 4, 2020
package.json
Outdated
| @@ -38,6 +38,7 @@ | |||
| "cosmiconfig": "^6.0.0", | |||
| "debug": "^4.1.1", | |||
| "dedent": "^0.7.0", | |||
| "enquirer": "^2.3.5", | |||
| "execa": "^4.0.1", | |||
| "listr2": "^2.0.2", | |||
There was a problem hiding this comment.
Let's bump this to "listr2": "^2.1.0" as well to keep it in sync. Remember to run yarn as well in so that the lockfile gets updated.
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 597 597
Branches 142 142
=========================================
Hits 597 597 Continue to review full report at Codecov.
|
|
For sure, updated listr2 as well. |
iiroj
approved these changes
Jun 4, 2020
|
Thanks a lot for this update, @philihp! 🚀 |
|
🎉 This PR is included in version 10.2.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enquirer became a peer dependency of Listr2 here: listr2/listr2@cae55e9
This should be added, so that repositories including lint-staged won't see the message