Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: truncate command title to stdout width #865

Merged
merged 1 commit into from
May 22, 2020
Merged

fix: truncate command title to stdout width #865

merged 1 commit into from
May 22, 2020

Conversation

iiroj
Copy link
Member

@iiroj iiroj commented May 15, 2020

This makes sure the task title is as long as possible to fit on a single line of the console output, applying both to regular and functional tasks.

okonet
okonet previously approved these changes May 16, 2020
View reviewed changes
@iiroj
Copy link
Member Author

iiroj commented May 16, 2020

Have to figure out how to handle test snapshots...

@iiroj iiroj mentioned this pull request May 16, 2020
Merged
@iiroj iiroj changed the base branch from master to updates May 17, 2020 11:10
@iiroj iiroj changed the base branch from updates to master May 20, 2020 15:12
@iiroj iiroj dismissed okonet’s stale review May 20, 2020 15:12

The base branch was changed.

@iiroj iiroj force-pushed the truncate-title branch from 6a99a17 to 527ac0a Compare May 20, 2020 15:32
@iiroj iiroj marked this pull request as ready for review May 20, 2020 15:32
@iiroj iiroj requested a review from okonet May 20, 2020 15:33
@iiroj iiroj force-pushed the truncate-title branch from 527ac0a to 91f8c41 Compare May 20, 2020 15:35
@iiroj iiroj mentioned this pull request May 20, 2020
Closed
@iiroj
Copy link
Member Author

iiroj commented May 20, 2020

@okonet I happened to find the expect.addSnapshotSerializer method, learned some new things, and applied it to work around the random filepath appearing in the snapshot!

@iiroj
fix: truncate command title to stdout width
508e869 
This makes sure the task title is as long as possible to fit on a single line of the console output, applying both to regular and functional tasks.
@iiroj iiroj force-pushed the truncate-title branch from 91f8c41 to 508e869 Compare May 20, 2020 15:41
@codecov
Copy link

codecov bot commented May 20, 2020 •
edited
Loading

Codecov Report

Merging #865 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #865   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          592       597    +5     
  Branches       141       142    +1     
=========================================
+ Hits           592       597    +5
Impacted Files Coverage Δ
lib/runAll.js 100.00% <ø> (ø)
lib/makeCmdTasks.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93bc942...508e869. Read the comment docs.

@iiroj iiroj merged commit b8e1a4a into master May 22, 2020
@github-actions
Copy link
Contributor

🎉 This PR is included in version 10.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iiroj iiroj deleted the truncate-title branch May 22, 2020 06:08
aried3r
aried3r reviewed May 25, 2020
View reviewed changes
package.json
@@ -33,6 +33,7 @@
},
"dependencies": {
"chalk": "^4.0.0",
"cli-truncate": "2.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I was wondering if there's a reason why this dependency was locked to a specific version instead of using ^?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason, I'm pretty sure I just installed it with yarn add. Thanks for noticing, I'll create a fix for relaxing to ^.

@iiroj iiroj linked an issue May 28, 2020 that may be closed by this pull request
Functional tasks do not have meaningful name #828
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aried3r aried3r aried3r left review comments

@okonet okonet okonet approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Functional tasks do not have meaningful name
3 participants
@iiroj @okonet @aried3r