Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use verbose renderer when TERM=dumb #782

Merged
merged 3 commits into from
Jan 29, 2020
Merged

fix: use verbose renderer when TERM=dumb #782

merged 3 commits into from
Jan 29, 2020

Conversation

iiroj
Copy link
Member

@iiroj iiroj commented Jan 27, 2020 •
edited
Loading

This PR adds detection for the TERM=dumb env variable and sets cli-output to use the verbose renderer, instead of the default dynamic one.

Fixes #781

@iiroj iiroj mentioned this pull request Jan 27, 2020
Closed
@codecov
Copy link

codecov bot commented Jan 27, 2020 •
edited
Loading

Codecov Report

Merging #782 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #782   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines         480    484    +4     
  Branches      107    108    +1     
=====================================
+ Hits          480    484    +4
Impacted Files Coverage Δ
lib/runAll.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fac11f...7f5092c. Read the comment docs.

@iiroj iiroj force-pushed the dumb-terminal branch 2 times, most recently from 0e08e7d to 201182a Compare January 27, 2020 18:49
@iiroj iiroj requested a review from okonet January 27, 2020 18:50
okonet
okonet previously approved these changes Jan 28, 2020
View reviewed changes
Copy link
Collaborator

@okonet okonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider renaming the bin file to *.js but other than that it's LGTM

.lintstagedrc.json Outdated Show resolved Hide resolved
@iiroj iiroj force-pushed the dumb-terminal branch 2 times, most recently from 32dfd49 to eb69c52 Compare January 28, 2020 12:07
@iiroj
Copy link
Member Author

iiroj commented Jan 28, 2020

What do you think now, @okonet?

@iiroj iiroj requested a review from okonet January 28, 2020 15:53
okonet
okonet approved these changes Jan 28, 2020
View reviewed changes
lib/runAll.js Show resolved Hide resolved
@iiroj iiroj merged commit 9c08e8e into master Jan 29, 2020
@iiroj iiroj deleted the dumb-terminal branch January 29, 2020 04:35
@okonet
Copy link
Collaborator

okonet commented Jan 29, 2020

🎉 This PR is included in version 10.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@snyk-bot snyk-bot mentioned this pull request Mar 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okonet okonet okonet approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable advanced terminal behavior when TERM is dumb
2 participants
@iiroj @okonet