Fix for working in subdir #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irectory differs from the current working directory
okonet
requested changes
Oct 14, 2016
| @@ -5,6 +5,6 @@ const path = require('path') | |||
| module.exports = function resolvePaths(filePaths, relativeTo) { | |||
| return filePaths.map((file) => { | |||
| if (!relativeTo) relativeTo = process.cwd() // eslint-disable-line | |||
| return path.resolve(process.cwd(), relativeTo, file.filename) | |||
| return path.resolve(process.cwd(), path.relative(process.cwd(), relativeTo), file.filename) | |||
There was a problem hiding this comment.
Do you need the first process.cwd() here?
There was a problem hiding this comment.
Can you also add a test and update the README for that?
| @@ -35,7 +35,7 @@ cosmiconfig('lint-staged', { | |||
| console.error(err) | |||
| } | |||
|
|
|||
| const tasks = generateTasks(config, resolvePaths(files)) | |||
| const tasks = generateTasks(config, resolvePaths(files, sgf.cwd)) | |||
There was a problem hiding this comment.
Can we set the cwd as a constant in the beginning and reuse? Don't like the coupling with another lib here.
cleanup path resolving Todo: create test and run tests
|
@TheWolfNL It says "WIP" — are you still doing some more work on this? |
|
i'm planning on creating a test this weekend, didn't have time to test this yet. |
|
@okonet I thought there were no tests written for the nested config yet, but apparently you've already wrote those 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix so the paths will be properly resolved and working when the git directory differs from the current working directory