fix: make sure deleted files aren't restored due to git bugs

[iiroj]

Fixes #561

Currently, version 10 only fixes some of the issues with deleted files getting restored when running lint-staged. This PR adds yet more checks to fix the remaining issues. The issue itself seems to be with the way git tracks files, and you can read more here in Stack Overflow.

I also updated some eslint rules to take into account the Node.js version bump, and after that refactored the file api to use fs.promises to simplify the code.

[codecov]

Codecov Report

Merging #778 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #778   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines         485    486    +1     
  Branches      106    107    +1     
=====================================
+ Hits          485    486    +1

Impacted Files	Coverage Δ
lib/index.js	100% <ø> (ø)	⬆️
lib/getStagedFiles.js	100% <ø> (ø)	⬆️
lib/resolveGitRepo.js	100% <100%> (ø)	⬆️
lib/gitWorkflow.js	100% <100%> (ø)	⬆️
lib/file.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b98a5ed...0121e8b. Read the comment docs.

[tremby]

I've given this a go, and it's working for all the tests I ran.

[okonet]

Some minor changes and it’s good to go.

[iiroj]

The test coverage decrease is due to current git versions not hitting the special case. I'll have to extract it back into a separate function so that it can be tested via a mock.

EDIT: Handled via a synthetic test to see that the method deletes untracked files when run.

[okonet]

I still think await would be more appropriate but I leave to you.

[iiroj]

@tremby If you don't mind, could you test this again after the rebase? There were some other related changes put into master.

[iiroj]

What about this, @okonet?

[okonet]

🎉 This PR is included in version 10.0.6 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[tremby]

@tremby If you don't mind, could you test this again after the rebase? There were some other related changes put into master.

Late response but I've tested again with the latest release. Looks good. Thanks.