feat: bump Node.js version dependency to at least 10.13.0 #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Node.js v8 is no longer supported because it will reach EOL on 2019-12-31
Codecov Report
@@ Coverage Diff @@
## beta #747 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 13 13
Lines 388 388
Branches 81 81
=======================================
Hits 385 385
Misses 3 3Continue to review full report at Codecov.
|
|
Thoughts, @okonet? I think this could be the last bit to v10 before release. |
iiroj
commented
Dec 3, 2019
okonet
reviewed
Dec 3, 2019
iiroj
force-pushed
the
bump-node-version
branch
from
c0dfb74 to
4dfccec
Compare
iiroj
added a commit
that referenced
this pull request
Dec 4, 2019
BREAKING CHANGE: Node.js v8 is no longer supported because it will reach EOL on 2019-12-31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the Node.js version requirement enforced by please-upgrade-node to at least
v10.13.0, which is the first Dubnium-titled new LTS version. Node.js v8 will reach EOL status on 2019-12-31.It also replaces v8 from the test matrix with v13.
As pointed out by #746, this breaking change would be a good fit to v10.
Fixes #746