Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly read config from stdin #1317

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix: correctly read config from stdin #1317

merged 1 commit into from
Aug 21, 2023

Conversation

iiroj
Copy link
Member

@iiroj iiroj commented Aug 21, 2023

Fixes #1316, which was broken when switching to async node:fs/promises. This feature didn't have any tests, and I was lazy it seems...

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9da8777) 100.00% compared to head (e603a08) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1317   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        28    +1     
  Lines          760       767    +7     
  Branches       199       199           
=========================================
+ Hits           760       767    +7     
Files Changed Coverage Δ
lib/messages.js 100.00% <100.00%> (ø)
lib/readStdin.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iiroj iiroj force-pushed the fix-config-stdin branch from 777713c to e603a08 Compare August 21, 2023 09:25
@iiroj
Copy link
Member Author

iiroj commented Aug 21, 2023

Ping @okonet a fresh bug introduced in v14 by using node:fs/promises wrong.

@iiroj iiroj merged commit fc3bfea into master Aug 21, 2023
@iiroj iiroj deleted the fix-config-stdin branch August 21, 2023 09:41
gisbdzhch pushed a commit to gisktzh/gb3-web_ui that referenced this pull request Sep 13, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [lint-staged](https://github.com/okonet/lint-staged) | devDependencies | major | [`^13.2.3` -> `^14.0.0`](https://renovatebot.com/diffs/npm/lint-staged/13.3.0/14.0.1) |

---

### Release Notes

<details>
<summary>okonet/lint-staged (lint-staged)</summary>

### [`v14.0.1`](https://github.com/okonet/lint-staged/releases/tag/v14.0.1)

[Compare Source](lint-staged/lint-staged@v14.0.0...v14.0.1)

##### Bug Fixes

-   fix reading config from stdin, introduced in v14.0.0 ([#&#8203;1317](lint-staged/lint-staged#1317)) ([fc3bfea](lint-staged/lint-staged@fc3bfea))

### [`v14.0.0`](https://github.com/okonet/lint-staged/releases/tag/v14.0.0)

[Compare Source](lint-staged/lint-staged@v13.3.0...v14.0.0)

##### Features

-   drop support for Node.js 14 ([#&#8203;1312](lint-staged/lint-staged#1312)) ([9da8777](lint-staged/lint-staged@9da8777))

##### BREAKING CHANGES

-   Please upgrade your Node.js version to at least `16.14.0`.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or rename PR to start with "rebase!".

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants