Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop support for Node.js 14 #1312

Merged
merged 1 commit into from
Aug 13, 2023
Merged

feat: drop support for Node.js 14 #1312

merged 1 commit into from
Aug 13, 2023

Conversation

iiroj
Copy link
Member

@iiroj iiroj commented Aug 13, 2023

BREAKING CHANGE: Please upgrade your Node.js version to at least 16.14.0.

BREAKING CHANGE: Please upgrade your Node.js version to at least `16.14.0`.
@iiroj iiroj requested a review from okonet August 13, 2023 18:12
@iiroj
Copy link
Member Author

iiroj commented Aug 13, 2023

Ping @okonet the PR #1289 didn't trigger a major version bump with feat! as expected, and the commit isn't visible in the release notes either. Probably an issue with semantic-release... let's see if this commit works better.

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f895e97) 100.00% compared to head (22b74ec) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1312   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          760       760           
  Branches       199       199           
=========================================
  Hits           760       760           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iiroj
Copy link
Member Author

iiroj commented Aug 13, 2023

Looks like we use the default config (angular) while ! is from conventional commits spec. Should probably set up a commit linter for this.

Copy link
Collaborator

@okonet okonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use changesets.

@iiroj
Copy link
Member Author

iiroj commented Aug 13, 2023

Yeah, that would be nice. I can look into it tomorrow!

@iiroj iiroj merged commit 9da8777 into master Aug 13, 2023
@iiroj iiroj deleted the trigger-breaking-change branch August 13, 2023 20:32
gisbdzhch pushed a commit to gisktzh/gb3-web_ui that referenced this pull request Sep 13, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [lint-staged](https://github.com/okonet/lint-staged) | devDependencies | major | [`^13.2.3` -> `^14.0.0`](https://renovatebot.com/diffs/npm/lint-staged/13.3.0/14.0.1) |

---

### Release Notes

<details>
<summary>okonet/lint-staged (lint-staged)</summary>

### [`v14.0.1`](https://github.com/okonet/lint-staged/releases/tag/v14.0.1)

[Compare Source](lint-staged/lint-staged@v14.0.0...v14.0.1)

##### Bug Fixes

-   fix reading config from stdin, introduced in v14.0.0 ([#&#8203;1317](lint-staged/lint-staged#1317)) ([fc3bfea](lint-staged/lint-staged@fc3bfea))

### [`v14.0.0`](https://github.com/okonet/lint-staged/releases/tag/v14.0.0)

[Compare Source](lint-staged/lint-staged@v13.3.0...v14.0.0)

##### Features

-   drop support for Node.js 14 ([#&#8203;1312](lint-staged/lint-staged#1312)) ([9da8777](lint-staged/lint-staged@9da8777))

##### BREAKING CHANGES

-   Please upgrade your Node.js version to at least `16.14.0`.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or rename PR to start with "rebase!".

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants