Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong path with gitDir #118

Closed
ai opened this issue Jan 11, 2017 · 0 comments
Closed

Wrong path with gitDir #118

ai opened this issue Jan 11, 2017 · 0 comments

Comments

@ai
Copy link
Contributor

ai commented Jan 11, 2017

My config is located in front/package.json and contains:

    "gitDir": "../",
    "*.sss": [
      "stylelint",
      "node ./front/postcss/sort",
      "git add"
    ],
    "*.js": "eslint"

If I was staged front/a.js file, lint-stage will execute front/node_modules/.bin/eslint a.js. There is no front/ in file path.

Maybe we should use absolute path there?
patrick91 added a commit to patrick91/lint-staged that referenced this issue Jan 14, 2017
@patrick91
Return files relative to git directory
402d9da 
It was returning files relative to the current working directory, not the git one.

Should also fix lint-staged#118
This was referenced Jan 14, 2017
Closed
Closed
rodneyrehm added a commit to rodneyrehm/lint-staged that referenced this issue Jan 15, 2017
@rodneyrehm
fix(index): consider paths relative to git root - lint-staged#118, li…
99bc144 
…nt-staged#120
@rodneyrehm rodneyrehm mentioned this issue Jan 15, 2017
Merged
@okonet okonet closed this as completed in 41ae0cb Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
1 participant
@ai