fix(resolvePaths): return CWD-relative paths - closes #115 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okonet
requested changes
Dec 30, 2016
| @@ -3,15 +3,13 @@ | |||
| import expect from 'expect' | |||
| import path from 'path' | |||
| import fs from 'fs' | |||
| import tmp from 'tmp' | |||
There was a problem hiding this comment.
Can you please also remove the package from package.json?
There was a problem hiding this comment.
removed in a separate commit
|
Thanks for this PR! I'd be happy to accept anything that could simplify it, so feel free to do a review. |
okonet
approved these changes
Dec 30, 2016
|
Awesome! Thanks for your contribution. The new version should be available soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115 by making resolvePaths() return paths that are relative to CWD. Should gitDir be set to
.., the returned path foralpha.jswould be../alpha.js.I haven't looked too closely at all of the path computations, but it feels like this could be simplified further.