-
-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependencies #1003
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1003 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 20 +1
Lines 641 646 +5
Branches 146 146
=========================================
+ Hits 641 646 +5
Continue to review full report at Codecov.
|
I rebased this and updated again, but it seems even more of @sindresorhus's packages have migrated to ESM and thus can no longer be updated. I was able to migrate lint-staged itself to ESM pretty easily, but the jest tests seem a bit more complicated. Some tests seems to fail because they "cannot use import statement outside a module", so it's probably related to Babel. What do you think, @okonet? |
Sorry but I don't have an opinion on that one. I'm not sure why we need to migrate to ESM since lint-staged can't be used as a dependency. |
To keep dependencies up-to-date, we need to either stop updating ESM deps, replace them, or convert to ESM ourselves. Lint-staged does expose a Node.js API: import lintStaged from "lint-staged"; Personally I'm fine with anything, although if we stay at CommonJS, it might make sense to inline some simpler dependencies into the project directly. |
Hmm, yeah I forgot about providing the Node API :) I'm fine with everything too but I see you point of being up to date i.e. for security reasons. Can we ping someone from Jest / Babel to help us with this? |
@okonet let's release all the updates we can do without changing anything, and then revisit once we know which dependencies can no longer be updated, and how the Node.js version requirements would change if we were to go to ESM. I need to rebase this branch. |
Ping @okonet this renovation got a little out of hand, and I also updated all the GitHub CI Action runners, as well as replace Thoughts? |
LGTM |
🎉 This PR is included in version 11.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 11.3.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
"debug": "^4.3.1", | ||
"cli-truncate": "2.1.0", | ||
"colorette": "^1.4.0", | ||
"commander": "^8.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency upgrade bumps the minimum node.js version from 10 to 12. So maybe that should be considered as breaking change instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It for sure should have been! Thanks for pointing this out. cc @iiroj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Maybe a fix
to downgrade? Or should we bump our version now that 16 is in LTS and 10 is getting old?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd bump and release as a major TBH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured we could go all the way and convert lint-staged to ESM: #1038
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we already require Node.js 12.13, we just don't enforce it via the engines.node
key:
This PR updates all top-level dependencies, expect for [email protected] which is now ESM-only and thus won't work in lint-staged until it is also converted to ESM.
What do you think, @okonet?