Adding a spider for AP Macapá #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I opted to perform one request per day, since lots of the entries on the website do not carry a date specification anywhere on the HTML body. I also noticed that the URL path (which includes a date) is not always a good representation for the actual date for that gazette. This will result in much more requests, but it's the way I found to assure that dates will be consistent, and no results will be skipped due to the lack of a date. See my comment on #217 |
phrfpeixoto
force-pushed
the
ap-macapa
branch
2 times, most recently
from
320eec0 to
7c9e1bf
Compare
|
Sorry! I unwillingly closed this trying to rebase my branch. Reopened. |
ejulio
approved these changes
Oct 3, 2020
jvanz
requested changes
Oct 6, 2020
jvanz
requested changes
Oct 7, 2020
jvanz
reviewed
Oct 8, 2020
jvanz
approved these changes
Oct 10, 2020
Closed
sergiomario
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my proposed solution for #180.
I know @rennerocha commented on that issue, PR #217 is already under review for this spider, but by the time I saw that comment, the code was already written, so I figured I should submit it anyway. At least I can get some comments and learn something.