Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Uberaba/MG spider #132

Merged
merged 3 commits into from
Oct 29, 2019
Merged

Add Uberaba/MG spider #132

merged 3 commits into from
Oct 29, 2019

Conversation

giovanisleite
Copy link
Contributor

@giovanisleite giovanisleite commented Oct 2, 2019 •
edited
Loading

  • Example of gazette with executive and legislature acts.

  • Two editions weren't using the same name pattern (one with an extra word "final" and other with "CONCURSOS",), but both were unique for the date, so I judged both as non-extra editions.

  • The "5000" limit is a magic number to avoid pagination.

@giovanisleite giovanisleite changed the title WIP - Add Uberaba/MG spider Add Uberaba/MG spider Oct 3, 2019
avelino
avelino approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Irio Irio merged commit 9c1dfa0 into okfn-brasil:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avelino avelino avelino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giovanisleite @avelino @Irio