#2441 - proposal notifications should have 'you' when I am the creator #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
sebin/task/#2441-notification-should-have-you
|
| Run status |
|
| Run duration | 08m 54s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
corrideat
reviewed
Dec 7, 2024
frontend/model/contracts/group.js
Outdated
| @@ -702,6 +702,7 @@ sbp('chelonia/defineContract', { | |||
| createdDate: meta.createdDate, | |||
| groupID: contractID, | |||
| creatorID: innerSigningContractID, | |||
| isCreator: innerSigningContractID === loggedIn.identityContractID, | |||
There was a problem hiding this comment.
Instead of isCreator, I think it'd be better to leave this as is, and add the creatorID to the PROPOSAL_CLOSED notification. Then, we can check for creator when the notification text is created. (The reason for doing it this way is to keep the contract code as less reliant on external state as possible).
corrideat
reviewed
Dec 7, 2024
frontend/model/contracts/group.js
Outdated
| sbp('gi.notifications/emit', 'PROPOSAL_CLOSED', { | ||
| createdDate: meta.createdDate, | ||
| groupID: contractID, | ||
| isCreator: loggedIn.identityContractID === proposal.creatorID, |
There was a problem hiding this comment.
|
@taoeffect Updated the PR for Ricardo's feedbacks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2441
Made fixes for
NEW_PROPOSALandPROPOSAL_CLOSEDnotifications.PROPOSAL_EXPIRINGdoes not need this fix because it is emitted only to those who have not voted yet. (Creator always votes for 'yes') But please let me know if I have missed anything here.