Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scalafmt #59

Open
laughedelic opened this issue Jul 17, 2017 · 7 comments
Open

Add Scalafmt #59

laughedelic opened this issue Jul 17, 2017 · 7 comments
Assignees
Milestone

Comments

@laughedelic
Copy link
Contributor

  • no more moving code around, same formatting for everyone: clearer diffs, easier to review PRs
  • Scalafmt released v1.0 some time ago and is now v1.1, so it's considered quite stable
  • Sbt has recently adopted Scalafmt for it's (quite big) codebase
  • There's an ongoing community discussion about creating a standard style guide, which is very good
@laughedelic laughedelic added this to the v1.0.0 milestone Jul 17, 2017
@laughedelic laughedelic self-assigned this Jul 17, 2017
@laughedelic
Copy link
Contributor Author

@eparejatobes do you have anything against it?

@eparejatobes
Copy link
Contributor

Nothing against scalafmt per se, a lot against the "official" style guide(s).

@laughedelic
Copy link
Contributor Author

laughedelic commented Aug 29, 2017

I read it as you're fine with using it with certain adjustments to the formatter configuration.

If certain means wiping out defaults completely, yes.

@laughedelic
Copy link
Contributor Author

I guess, you meant to reply instead of editing my message.

wiping out defaults completely

I don't get it. You want to write your own formatting config from scratch and maintain it?

@eparejatobes
Copy link
Contributor

I don't get it. You want to write your own formatting config from scratch and maintain it?

If I'm using scalafmt, yes.

@eparejatobes
Copy link
Contributor

Yes, I wanted to reply, sorry 😆

@laughedelic
Copy link
Contributor Author

laughedelic commented Aug 29, 2017

If I'm using scalafmt, yes.

Why? Is the default one so bad and unappealing to you? (did you check it?) Why wasting time doing it from scratch instead of reusing the default and tweaking a couple of things that you don't like? (I don't like it either)

Anyway, if you are really going to do it, it's fine with me. I just want to have a unified automatic formatting and simplify diffs in PR reviews..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants