-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*BSD/macOS do not have 'echo -e' #606
Comments
Oh My Bash is not written in the portable POSIX shell. Oh My Bash is written in the Bash language because it is a set of settings for Bash. The command That said, with specific combinations of the shell settings, (
Could you wait for a while before starting to work on it? I have conflicting changes to the calls of |
I merged my local branch in the master and pushed it (770d6ef). Some of |
Some remarks:
This is a file that is intended to be used as an independent executable script, so it is hard to consider the case it is used with the unusual combination of the shell options
This file is synced with the completion file provided by the upstream Subversion project [1], so we would like to avoid custom changes on our side as much as possible. You should first ask the upstream Subversion project to fix [1] https://svn.apache.org/repos/asf/subversion/trunk/tools/client-side/bash_completion |
akinomyoga wrote:
<snip />
<snip /> OK... I just used
akinomyoga wrote:
OK...thanks... akinomyoga wrote:
<snip /> I had an On FreeBSD, you have to explicitly install It would be very hard to port oh-my-bash to the POSIX shell because of its heavy use of arrays (among other things). <snip />
Yes, they're disabled in my invocation of <snip />
OK... All that being said, Thanks for your help. |
I have a
you could write
It handles all the common text attributes (bold, italic, underline, etc), 4-bit (foreground) color and 8-bit foreground/background color. This is common stuff on |
Yes, but we don't intend to port it. We don't expect users to try that either; users can still try, but we are not going to help such users.
In Oh My Bash (OMB), it is supposed to be replaced with something like this _omb_util_print "\[$_omb_term_bold\]this is bold text\[$_omb_term_normal\]"
Since the command substitutions have a fork cost (and we continue to support Bash 3.2 where Bash-5.3's function and value substitutions are not going to be available), we want to continue to cache the results of $ compgen -v _omb_term_ |
akinomyoga wrote:
Ah...OK... I'll have a look. Pardon my ignorance but I only started using oh-my-bash a few days ago -- to rewrite some scripts I've supported for > 20 years that were getting pretty long in the tooth. |
I'm not a GitHub wizard... I'm having some problems. I'm able to clone the repo locally:
I can create a local branch:
I can't push the local branch to the remote:
Do you have to do something to allow this to happen? TIA... |
Which web page or documentation did you reference in learning how to make a pull request? I think you should find another web page that correctly describes the procedure. In short, you need to create your own remote copy of the repository by pressing the "Fork" button on GitHub. Then, in your local repository, you need to set up the references to the remote repositories correctly. You can use the following commands: $ cd <your local repository>
$ git remote rename origin upstream
$ git remote add origin [email protected]:sw030453/oh-my-bash.git
$ git fetch origin Please search the internet by yourself if you want to learn what each command does. |
I know what all that does…. Like I said, I’m not a GitHub wizard. Thanks for your quick response. |
OK... I have a working repo. I did a couple of innocuous changes and committed them to make sure my repo works. I have some questions:
Thanks in advance... |
Not really. We have a test for the installation script in
You can use it everywhere (except in Lines 109 to 117 in 770d6ef
As is observed in the above part, line 111 loads |
I'm all done making changes. Examine the file files.txt for a summary of what exactly I did. I'm using my repo in two different installations of oh-my-bash:
I'll generate a pull request in a couple of days. There were some files where I changed
to
You can look at the
to make
to make |
I don't have any conclusive opinion about them until I see the actual changes (instead of just a list of changed files), but the following files have the respective upstream repositories. Since we just copy the file from the upstream occasionally, we wouldn't want to change it on our side. The changes should be first introduced in the upstream and then should be pulled to our repository.
I don't remember whether the other files have corresponding upstream one by one, so there might be a few other files that we don't want to change. It also depends on the size of the changes, so I'll judge them after checking the submitted PR. Also, please be prepared that I normally request additional changes in PRs after reviewing the PRs. It's normal, and it's independent of the PR quality.
That seems useful but it doesn't seem to be POSIX. As far as I check XCU 3 env in the online publication of IEEE 1003.1-2024, the option |
akinomyoga wrote:
OK... I've backed all those out. There were only about a half-dozen or so. akinomyoga wrote:
I spent a very long time writing software professionally (prob more years than you are old). I would be alarmed if you didn't do this... ;-) |
Thank you for your understanding. Some people new to OSS seem to feel offended when they first receive many requests for changes on their work. I don't have prior knowledge about the OSS experience of the PR submitter, with whom I communicate through the internet, so just in case, I wanted to tell that one doesn't need to worry when they receive many requests on the PR. |
BSD-derived systems ( {Free,Net,Open}BSD & macOS ) do not have
echo -e
. This causes oh-my-bash to fail in unexpected ways. It's a simple matter to fix it...but you should stop using it and useprintf
instead (and modifying your CONTRIBUTING guidelines). Here is a list of files that currently use it:As soon as I get done with what I'm currently working on, I'll attempt a fix and submit a pull request.
Alternatively, you can install GNU coreutils and
alias echo=/usr/local/bin/gecho
but that seems to be a pretty heavyweight solution.
The text was updated successfully, but these errors were encountered: